Migrate Antora version update to GitHub [DI-719][DI-674]#2251
Conversation
|
Preview deployment: https://6a5e4cdc8353c972a0f46a9a--hazelcast-docs-uat.netlify.app |
nishaatr
changed the title
nishaatr
changed the title
39888c9 to
1488e02
Compare
|
If were adding Python to CI, we should continue also adding https://github.com/hazelcast/rel-scripts/blob/master/.github/workflows/validate-python.yml |
| jobs: | ||
| test: | ||
| # Ignore automated release PR branches | ||
| if: ${{ !startsWith(github.head_ref, 'update_antora_') }} |
There was a problem hiding this comment.
Do we also need to filter this out for the other validations, e.g.
hz-docs/.github/workflows/deploy-preview.yml
Lines 4 to 5 in f8e621b
There was a problem hiding this comment.
added v/*
8aeaf6e
actually, I added 'update_antora_' check simply because PR builder started running for release PR in sandbox even though the auto generated release PRs didn't update any scripts and if was present. May be because my changes are still in my branch but not sure. So I removed it from the other two docs PR builder but forgot to clean-up here
But now I am thinking should keep the if check + branches: [main, 'v/*'] as makes sense?
There was a problem hiding this comment.
I think my concern was not about maintenance branches and more about this special branch triggering actions on other workflows.
There was a problem hiding this comment.
yes need to I think. Kind of thought of this before
I first looked at maven-pr-builder.yaml and then checked other PR builder and didn't see any exclusions e.g. in deploy-preview.yml and kind of thought no need.
I will exclude in these:
build-site.yml
deploy-preview.yml
the others don't think need exclusion
I will revert 8aeaf6e as should not really trigger for v/branch
| run-name: ${{ github.workflow }} (`${{ inputs.VERSION }}`@${{ inputs.ENVIRONMENT }}) | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Doesn't have a comment, but promote does.
| prepare: | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - name: Logging distinct ID (${{ inputs.distinct_id }}) | ||
| run: echo "${DISTINCT_ID}" | ||
| env: | ||
| DISTINCT_ID: ${{ inputs.distinct_id }} |
There was a problem hiding this comment.
Might as well add as a step in package to avoid starting a runner just to print the message and burning credits.
Co-authored-by: Jack Green <jack.green@hazelcast.com>
Co-authored-by: Jack Green <jack.green@hazelcast.com>
Co-authored-by: Jack Green <jack.green@hazelcast.com>
Co-authored-by: Jack Green <jack.green@hazelcast.com>
2 participants
Details
Adds scripts and workflows to update Hazelcast
antora.ymlversion updates:mainbranch versions to the currenthazelcast-mono@masterPOM version2. updates
releasebranch to the current release.releasebranch version with the current release version.v/branchfrom the release branch during thepromotephase. This must happen duringpromotebecausev/branchmakes the Docsgo-live.Additional fix
Release 5.6.0 - remove SNAPSHOT from verion: in hz-docs (DI-674)
Updates below fields which were previously ignored by Release Pipeline
Testing
Tested in
sandbox.ReleaseInfogenerated via Centralized release info [DI-719][DI-835] mono-actions#26packageandpromote) triggered manuallyFollowing are the merged PRs by release version
Pre merge
DI-719-migrate-antora-1tomainFixes: DI-719, DI-674